-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: compatible with qq browser on ios, close #294 #366
Conversation
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
==========================================
+ Coverage 56.86% 59.30% +2.43%
==========================================
Files 16 16
Lines 728 747 +19
Branches 113 162 +49
==========================================
+ Hits 414 443 +29
+ Misses 303 293 -10
Partials 11 11 β View full report in Codecov by Sentry. |
Thanks for the PR. I would love to have further investigation before merging this (otherwise ofetch ends up with lots of old browser compatibility fixes) Do you mind to make a minimal testing environment (html+js) and share the browser version/platform required to verify. |
Dear @pi0οΌI apologize, but I am unable to provide a reproducible test case. On one hand, it only occurs in the QQ Browser on iOS, and I am not very clear about the WebKit version being used (my phone is running iOS 17).Β Also, I am not very familiar with testing on old browsers, so I apologize for not being able to provide a shareable test environment. π |
Okay, no worries. I will try to assemble a reproduction env once could but it is essential before we can move it forward I hope it is reasonable. |
Thank you π₯° |
This comment was marked as off-topic.
This comment was marked as off-topic.
If someone doesn't have high stability requirements, they can use this module β markthree/nuxt-fix-ofetch |
Seems to be fixed in the latest QQ browser @markthree can you confirm? |
Yes, the problem still exists, it's a problem with ofetch, and it can be reproduced when using it solely |
From @xjccc comment:
But you have issue with these versions and ofetch? |
yes, QQ Browser version: 15.1.7 |
Thanks to the ref β nuxt-fix-ofetch/src/runtime/00.fetch.client.ts#L52-#L86 |
I upgrade my QQ Browser version: 15.1.7.5928 iOS version: 17.5.1
my web site works fine.. |
Hi dear @markthree Again sorry this took long. We have merged a relative fix in #398 that passes I think we might add an improvement to check if body is blob, use .stream() |
Thanks @pi0, looks great, ofetch is much easier to use. |
π Linked issue
#294
nuxt/nuxt/issues/25956
nuxt/nuxt/issues/24229
β Type of change
π Description
This doesn't look perfect, but after manual testing, everything runs smoothly and there are no break change.
The reason may be that the core used by these browsers has not yet implemented
response.body
π€£π Checklist